Re: [PATCH] Please define thread_info as struct thread_info (and other stuff)

[Tom Tromey <tom at tromey dot com>]

>>>>> "Svante" == Svante Signell <svante.signell@gmail.com> writes:

Svante> When building gdb version 8.2 on GNU/Hurd several problems arise that need to be
Svante> solved. One problem is that most files in gdb/ have sloppy definitions of struct
Svante> thread_info, causing a build stop fore every occurrence. They are excluding the
Svante> struct part, making the build (and port) on Hurd very cumbersome. Can you please
Svante> fix all bad references to thread_info upstream? I don't really understand how
Svante> gcc can let these errors pass on GNU/Linux.

In C++ there's an implicit typedef for a struct tag, so "struct
thread_info" can also just be referred to as "thread_info".  So, I tend
to think the code is fine and something else is going wrong.

You didn't post the text of the error or the version of the compiler
that you are using, so it's hard to say more about what the problem is.
Could you send that info?

Svante> More patches will be needed for a successful port of gdb-8.2 to GNU/hurd, but
Svante> please fix the above problems upstream first.

I didn't go through all the patches, but I suggest sending a series
rather than one large message; following the contribution checklist; and
finally, working off git master rather than a branch.

thanks,
Tom