This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Factorize killing the children in linux-ptrace.c, and fix a 'process leak'.
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: Pedro Alves <palves at redhat dot com>, Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Sun, 16 Dec 2018 21:27:44 +0100
- Subject: Re: [RFA] Factorize killing the children in linux-ptrace.c, and fix a 'process leak'.
- References: <20181103201929.10345-1-philippe.waroquiers@skynet.be> <3830a73e-d630-1176-b6e9-00f88ed6468d@ericsson.com> <734d1ee3-c452-bf04-0084-26a59238a139@redhat.com> <1541957075.1531.1.camel@skynet.be> <1d75a834a31293c79f8ffb6188a059d6@polymtl.ca>
On Fri, 2018-12-14 at 18:39 -0500, Simon Marchi wrote:
>
> Not sure if you got that far in your archeology, but here is the
> discussion about it:
>
> https://sourceware.org/ml/archer/2011-q1/msg00102.html
>
> which is a reply to:
>
> https://sourceware.org/ml/archer/2010-q3/msg00209.html
>
> Realistically, we could probably just get rid of using PTRACE_KILL.
>
> Please push the patch. I think it's totally fine to do one small step
> at the time. As you said, it's already a significant improvement.
>
> Simon
Thanks for the review, I have pushed the patch, and added on my
list of things to do (one day) to work on a bigger cleanup.
Philippe