Re: [PATCH] fix compile error with clang

[Dave Murphy <davem at devkitpro dot org>]

Hi Simon,

The error I get is

../../binutils-gdb/gdb/unittests/observable-selftests.c:73:31: error:
default initialization of an object of const type 'const
gdb::observers::token' without a user-provided default constructor
  const gdb::observers::token token1, token2, token3;
                              ^
                                    {}
clang version is

davem@devkit-builder:~$ /opt/osx/bin/x86_64-apple-darwin15-clang --version

clang version 3.8.1-24 (tags/RELEASE_381/final)
Target: x86_64-apple-darwin15
Thread model: posix

(targeting 10.9+ host)

build machine is debian stretch

davem@devkit-builder:~$ uname -a
Linux devkit-builder 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2
(2018-10-27) x86_64 GNU/Linux


Dave

On Thu, Dec 20, 2018 at 7:25 PM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2018-12-20 12:25, Dave Murphy wrote:
> > Cross compiling for macOS using osxcross gives errors of the form
> > "error: default initialization of an object of ... without a
> > user-provided default constructor"
> >
> > Fixed by attached patch, tested compile with mingw-w64, osxcross and
> > linux native builds.
> >
> > 2018-12-20  Dave Murphy  <davem@devkitpro.org>
> >
> >     * gdb/dtrace-probe.c (dtrace_static_probe_ops): explicit zero
> > initialise.
> >     * gdb/probe.c (any_static_probe_ops): ditto
> >     * gdb/record-btrace.c (record_btrace_thread_observer_token): ditto
> >     * gdb/stap-probe.c (stap_static_probe_ops): ditto
> >     * gdb/tui/tui-hooks.c (tui_observers_token): ditto
> >     * gdb/unittests/observable-selftests.c (token1, token2, token3):
> > ditto
>
> Hi Dave,
>
> Could you mention which exact compiler version you are using (output of
> --version), and paste one instance of the exact error message?  I'm
> trying to see why I don't see this when building with clang natively on
> both macOS and Linux.
>
> Simon