This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/12] Remove some ALL_* iteration macros
- From: Tom Tromey <tom at tromey dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 24 Dec 2018 13:54:49 -0700
- Subject: Re: [PATCH 00/12] Remove some ALL_* iteration macros
- References: <20181125165439.13773-1-tom@tromey.com> <20181223070033.GB8096@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> As for the downside, I don't consider re-indentation a downside
Joel> other than it makes review a bit more painful. The two-nested
Joel> loop didn't seem like they were making the code less readable.
Joel> Did you have any other concerns with that?
Nope.
Joel> I admit I was scanning the last few patches much faster than the first
Joel> few ones, but they seem fairly mechanical to me, so I think the risk
Joel> is low.
I think I will have to redo much of the series to account for that
version of gcc that Simon sometimes uses -- the one that requires ranged
for loops to use the "struct" keyword. I probably can't really test
that change but I'll make a best effort at it in order to reduce the
amount of work he has to do.
Tom