This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Build gdb "nat" files in subdirectory

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 27 Dec 2018 13:03:10 -0700
Subject: Re: [PATCH 3/3] Build gdb "nat" files in subdirectory
References: <20181224210927.16741-1-tom@tromey.com> <20181224210927.16741-4-tom@tromey.com> <a94ae4ba-eb79-876a-593d-0eeeb0da92a1@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I wrote a small script scraping all .o file names from configure.nat, to
Simon> see if there is a corresponding .c file (see below if you need it).  The
Simon> only bad one it found is "nat/aarch64-sve-nat/linux-ptrace.o", which should
Simon> just be nat/linux-ptrace.o, I think.

Thanks for doing that.  I think the one bad one should be
nat/aarch64-sve-linux-ptrace.o, so I've made that change.

Simon> Other than that, it did fine the _U/_S files for Hurd (e.g. notify_S.o).  There
Simon> is no corresponding .c file for that, I don't know if they are generated or what,
Simon> but I don't think your patch changes anything about that.

I believe they are generated in the build tree.

Simon> Overall this series LGTM, thanks!

I'm going to push the updated series.  Thanks for the review.

Tom

References:
- [PATCH 0/3] some minor Makefile improvements
  - From: Tom Tromey
- [PATCH 3/3] Build gdb "nat" files in subdirectory
  - From: Tom Tromey
- Re: [PATCH 3/3] Build gdb "nat" files in subdirectory
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]