This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/12] Make use of default gdbarch methods for some targets
- From: Simon Marchi <simark at simark dot ca>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Cc: alan dot hayward at arm dot com, abidh at codesourcery dot com, Anton dot Kolesov at synopsys dot com, hp at axis dot com, jamesb at excamera dot com, vapier at gentoo dot org
- Date: Thu, 27 Dec 2018 17:01:36 -0500
- Subject: Re: [PATCH 00/12] Make use of default gdbarch methods for some targets
- References: <cover.1545918068.git.andrew.burgess@embecosm.com>
On 2018-12-27 9:08 a.m., Andrew Burgess wrote:
> Following on from this patch:
>
> https://sourceware.org/ml/gdb-patches/2018-11/msg00132.html
>
> This series removes the dummy_id, unwind_pc, and unwind_sp gdbarch
> methods from some targets in cases where it seems obvious that the
> default method, and the method being deleted are the same.
>
> From this series only the RISC-V patch has been tested (due to lack of
> targets), so I'm relying on manual code inspection to convince myself
> the patches are correct.
>
> I've CC'd target maintainers where I can find any in the hope people
> might test their own target, however, not every target has an obvious
> maintainer, so some are going to rely on review.
>
> I've not adjusted every target, this is about half. I wanted to see
> if it's possible to get this set of changes accepted before I do the
> remaining set. I don't think updating half the targets now, and half
> later will leave GDB in a worse state.
>
> Final note, all of these patches are independent, each should apply
> cleanly without the preceding patches, so feel free to review any that
> are of interest, I'll push patches as they get approval.
Hi Andrew,
This LGTM. But let's give arch maintainers some time to take a look if
they want. Since people may be on vacation right now, I'd say let's wait
until around January 15th to give them a chance. If you don't hear anything
else, then please push then.
Thanks!
Simon