This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH 03/12] gdb/arc: Use default gdbarch method default_dummy_id.


> -----Original Message-----
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Sent: Thursday, December 27, 2018 17:08
> To: gdb-patches@sourceware.org; Anton.Kolesov@synopsys.com
> Cc: alan.hayward@arm.com; abidh@codesourcery.com; hp@axis.com;
> jamesb@excamera.com; vapier@gentoo.org; Andrew Burgess
> <andrew.burgess@embecosm.com>
> Subject: [PATCH 03/12] gdb/arc: Use default gdbarch method
> default_dummy_id.
> 
> Make use of the default gdbarch method for gdbarch_dummy_id.
> 
> I have not tested this change but, by inspecting the code, I believe the default
> methods are equivalent to the code being deleted.
> 
> The arc target supplies its own gdbarch_unwind_pc method that includes
> custom debug output, in all other respects the arc method is the same as
> default_unwind_pc, however I have left the arc method in place so that the
> debug can remain.

Hi Andrew,

LGTM. FWIW, I think custom unwind_pc could be removed as well, if it only
adds extra logging and nothing else.

Anton


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]