This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 03/16] Introduce ui_file_style
- From: Tom Tromey <tom at tromey dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 28 Dec 2018 11:54:44 -0700
- Subject: Re: [PATCH 03/16] Introduce ui_file_style
- References: <20181128001435.12703-1-tom@tromey.com> <20181128001435.12703-4-tom@tromey.com> <20181224034018.GG5246@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> + /* Can't call this for a basic color. */
Joel> I am trying to understand this comment, as well as the corresponding
Joel> comment describing this method (in ui-style.h):
Joel> + This may not be called for simple colors or for the "NONE"
Joel> + color. */
Joel> Does it look like you can, in fact, call this method on
Joel> a simple color?
Yeah. The naming was confusing here, so I have cleaned it up by
renaming "enum simple_color" to "enum basic_color". You can call this
method for any "simple" (scalar) color that isn't a basic color or NONE,
simply because we don't have RGB values for these.
>> + ui_file_style ()
>> + {
>> + }
Joel> Sorry for the obvious C++ question - Does this constructor means
Joel> that the default constructor results in an object with undefined
Joel> data? Or is that the same as...
Joel> ui_file_style () = default;
It's the same, I have changed the code to use the "= default" form.
Joel> I think there might be a copy-pasto in the comment: N_READ -> BYTES?
I fixed this.
Tom