This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix 'help set/show style' strange layouts/results.
- From: Tom Tromey <tom at tromey dot com>
- To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 29 Dec 2018 12:19:08 -0700
- Subject: Re: [RFA] Fix 'help set/show style' strange layouts/results.
- References: <20181229155116.6603-1-philippe.waroquiers@skynet.be>
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> This could be fixed by having set_prefix_doc and show_prefix_doc instead of
Philippe> the single prefix_doc argument to cli_style_option::add_setshow_commands.
Philippe> That could be improved if deemed better.
Up to you.
Philippe> 2018-12-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
Philippe> * cli/cli-style.c (cli_style_option::add_setshow_commands):
Philippe> Initialize m_set_prefix with "set", instead of re-assigning
Philippe> m_show_prefix. Use m_set_prefix for set_list and m_show_prefix
Philippe> for show_list.
Philippe> (_initialize_cli_style): Correct the order of arguments in
Philippe> variable_name_style.add_setshow_commands and
Philippe> address_style.add_setshow_commands calls.
This is ok. Thanks for noticing and fixing this.
Tom