This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Fix leak in most gdb.mi tests.

From: Tom Tromey <tom at tromey dot com>
To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sun, 30 Dec 2018 08:54:57 -0700
Subject: Re: [RFA] Fix leak in most gdb.mi tests.
References: <20181229170116.8588-1-philippe.waroquiers@skynet.be> <87a7kom9ez.fsf@tromey.com> <871s60m8lg.fsf@tromey.com> <87wonsktj2.fsf@tromey.com> <1546162107.12900.3.camel@skynet.be>

>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

Philippe> The patch looks nice to me.  I re-run all gdb.mi tests under valgrind,
Philippe> and no errors/no leak of the line_buffer.
Philippe> A minor comment below.

Thanks for taking a look.

>> @@ -594,7 +594,7 @@ command_handler (const char *command)
>> line ends in a backslash).  Takes ownership of RL.  */

Philippe> Remove the part of the comment about ownership ?

I'm checking it in with this change.

Tom

Follow-Ups:
- Re: [RFA] Fix leak in most gdb.mi tests.
  - From: Philippe Waroquiers

References:
- [RFA] Fix leak in most gdb.mi tests.
  - From: Philippe Waroquiers
- Re: [RFA] Fix leak in most gdb.mi tests.
  - From: Tom Tromey
- Re: [RFA] Fix leak in most gdb.mi tests.
  - From: Tom Tromey
- Re: [RFA] Fix leak in most gdb.mi tests.
  - From: Tom Tromey
- Re: [RFA] Fix leak in most gdb.mi tests.
  - From: Philippe Waroquiers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]