This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Readline: Cleanup some warnings
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: Tom Tromey <tom at tromey dot com>, Joel Brobecker <brobecker at adacore dot com>
- Cc: Alan Hayward <Alan dot Hayward at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Fri, 01 Feb 2019 19:54:08 +0100
- Subject: Re: [PATCH] Readline: Cleanup some warnings
- References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <F71F4EDA-CBDF-4B05-B9C2-588D02471EB2@arm.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> <20190201080533.GA31043@adacore.com> <877eejvfoq.fsf@tromey.com>
On Fri, 2019-02-01 at 05:47 -0700, Tom Tromey wrote:
> > > > > > "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>
> Joel> Thank you. It's always better if it is an exact backport, because
> Joel> it facilitates future resyncs with the upstream versions.
>
> Speaking of, I still have a branch with a newer import on it. It could
> use some more testing. It's been a while since I poked at this, so I
> don't really remember, but I think it fails a couple of gdb tests. So,
> some readline debugging is also needed.
To solve a leak, I now configure/build GDB to use
the debian stable readline, and I only have one more
test failing compared to the GDB 6.2:
"This 'by design' leak is fixed in readline 7, while
the GDB readline version is 6.2 according to the last
'import' message in readline ChangeLog.gdb.
On my system (debian 9.6), the leaks are fixed by using
--with-system-readline=yes
with the system readline version being 7.0-3
Switching to this readline version causes the following checks to fail:
FAIL: gdb.gdb/selftest.exp: send SIGINT signal to child process (timeout)
FAIL: gdb.gdb/selftest.exp: thread 1 (timeout)
FAIL: gdb.gdb/selftest.exp: backtrace through signal handler (timeout)
Apart of that, no problem seen."
Philippe