This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Normalize include guards in gdb
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Sun, 3 Feb 2019 10:37:31 -0700
- Subject: Re: [RFC] Normalize include guards in gdb
- References: <20190127195637.13769-1-tom@tromey.com>
On Sun, 27 Jan 2019 12:56:37 -0700
Tom Tromey <tom@tromey.com> wrote:
> While working on my other scripts to deal with gdb headers, I noticed
> that some files were missing include guards. I wrote a script to add
> the missing ones, but found that using the obvious names for the
> guards ran into clashes -- for example, gdb/nat/linux-nat.h used
> "LINUX_NAT_H", but this was also the script's choice for
> gdb/linux-nat.h.
>
> So, I changed the script to normalize all include guards in gdb. This
> patch is the result.
>
> As usual the script is available here:
>
> https://github.com/tromey/gdb-refactoring-scripts
>
> Tested by rebuilding. I am not sure if this is too big for the
> buildbot, but I can try if the idea seems ok.
I didn't read the entire patch, but I scrolled through it examining
at least a dozen of the include guard changes. They all looked
reasonable to me.
Kevin