This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFAv2 3/3] Make symtab.c better styled.
- From: Pedro Alves <palves at redhat dot com>
- To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>, gdb-patches at sourceware dot org
- Date: Thu, 7 Feb 2019 18:58:00 +0000
- Subject: Re: [RFAv2 3/3] Make symtab.c better styled.
- References: <20190112222835.16932-1-philippe.waroquiers@skynet.be> <20190112222835.16932-4-philippe.waroquiers@skynet.be>
On 01/12/2019 10:28 PM, Philippe Waroquiers wrote:
> @@ -4667,8 +4685,15 @@ print_msymbol_info (struct bound_minimal_symbol msymbol)
> else
> tmp = hex_string_custom (BMSYMBOL_VALUE_ADDRESS (msymbol),
> 16);
> - printf_filtered ("%s %s\n",
> - tmp, MSYMBOL_PRINT_NAME (msymbol.minsym));
> + fputs_styled (tmp, address_style.style (), gdb_stdout);
> + fputs_filtered (" ", gdb_stdout);
> + if (msymbol_type_text_p (msymbol))
> + fputs_styled (MSYMBOL_PRINT_NAME (msymbol.minsym),
> + function_name_style.style (),
> + gdb_stdout);
> + else
> + fputs_filtered (MSYMBOL_PRINT_NAME (msymbol.minsym), gdb_stdout);
> + fputs_filtered ("\n", gdb_stdout);
Should this use the existing msymbol_is_function instead?
Thanks,
Pedro Alves