This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFAv2 3/3] Make symtab.c better styled.
- From: Pedro Alves <palves at redhat dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>, gdb-patches at sourceware dot org
- Date: Tue, 12 Feb 2019 15:53:30 +0000
- Subject: Re: [RFAv2 3/3] Make symtab.c better styled.
- References: <20190212145443.E2799D8028D@oc3748833570.ibm.com>
On 02/12/2019 02:54 PM, Ulrich Weigand wrote:
> Pedro Alves wrote:
>
>> So the question becomes a simple cosmetic one. In this case:
>>
>>> (gdb) info variables
>>> [...]
>>> Non-debugging symbols:
>>> 0x0000000010020088 main
>>
>> Should "main" be printed with function style, or variable style.
>> This basically affects the color used to print the symbol.
>>
>> In Philippe's patch, we'd print it in variable style. If we used
>> msymbol_is_function instead of his "is text symbol" check, we'd
>> print it in function style.
>
> Ah, I see. I guess that doesn't really matter that much at this
> point. Since we're already showing it under "variables" we might
> as well use the variable style. But in the end either way would
> be fine with me ...
OK, in that case, let's just use with Philippe already has.
Thanks,
Pedro Alves