This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] include/dis-asm.h: Fix warning: Include "string.h" for strchr
- From: Tom Tromey <tom at tromey dot com>
- To: Stafford Horne <shorne at gmail dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, GDB patches <gdb-patches at sourceware dot org>
- Date: Tue, 12 Feb 2019 14:55:26 -0700
- Subject: Re: [PATCH 2/3] include/dis-asm.h: Fix warning: Include "string.h" for strchr
- References: <20181202130510.10056-1-shorne@gmail.com> <20181202130510.10056-3-shorne@gmail.com> <a21f0654-a80a-e0e2-c826-98a966641621@ericsson.com> <20190127032907.GW3235@lianli.shorne-pla.net>
>>>>> "Stafford" == Stafford Horne <shorne@gmail.com> writes:
I didn't see a reply to this, apologies if I missed it somehow.
Stafford> I thought about this when I made this patch, we currently have a lot of these
Stafford> HAVE_XXX_H checks throughout the sim code. I am not sure of the history, but
Stafford> perhaps I can try a patch set to eliminate a few of them like HAVE_STRING_H vs
Stafford> HAVE_STRINGS_H (BSD). I would think everything we need is in on every machine
Stafford> in <string.h>.
The old BSD one is surely long obsolete.
The sim could also consider using gnulib. This isn't totally trivial --
we'd probably have to move it to the top level, though I've wanted us to
do that for a while now -- but it would mean not having to care so much
about checking for standard headers.
Stafford> I am not an expert in C/C++ compatibility. Is there at minimum standard c/c++
Stafford> required for gdb? Perhaps this has changed since we moved to allow C++.
gdb uses C++11. The rest of the tree uses C89 as far as I know.
Tom