This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fix pager bugs with style output


> Andrew> I don't have a solution, but the issue here is that in
> Andrew> user_select_syms output is produced with printf_unfiltered, by passing
> Andrew> the line wrapping buffer, however, the symbol name is produced by a
> Andrew> call to ada_print_symbol_signature which uses fprintf_filtered,
> Andrew> placing the output into the line wrap buffer.
> 
> Thanks for looking into this.
> 
> Andrew> You'll need to reconcile these two things.
> 
> Andrew> Given that ada_print_symbol_signature only seems to be called in areas
> Andrew> that are using unfiltered printing, simply changing
> Andrew> ada_print_symbol_signature to also use unfiltered printing should
> Andrew> provide a solution.
> 
> How about having user_select_syms also use filtered output?
> That seems like it would be somewhat friendlier in the unlikely event
> that the menu was very long -- it would give the user a chance to read
> the choices.

I think it makes sense, especially now that you enhanced the paging
to allow us to print everything without being asked about paging
anymore. It should be fairly easy to revert back if we find that
this is causing unforseen problems.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]