This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed][PATCH v3 1/4] Extended-remote follow exec
- From: Tom Tromey <tom at tromey dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>, <834575 at bugs dot debian dot org>, <834575-forwarded at bugs dot debian dot org>, <bug-hurd at gnu dot org>, <svante dot signell at gmail dot com>
- Date: Thu, 14 Feb 2019 10:26:25 -0700
- Subject: Re: [pushed][PATCH v3 1/4] Extended-remote follow exec
- References: <1441996698-12694-1-git-send-email-donb@codesourcery.com> <87vauuiqkj.fsf@euler.schwinge.homeip.net> <49527ebd-a1b3-fff2-fc59-bb557e6d0c50@redhat.com> <87a7iyiao5.fsf@euler.schwinge.homeip.net>
>>>>> "Thomas" == Thomas Schwinge <thomas@codesourcery.com> writes:
Thomas> + struct cleanup *old_chain = make_cleanup (xfree, pathname);
Please don't add new cleanups to gdb.
We're in the process of removing them all.
Instead you can use gdb::unique_xmalloc_ptr<char>, or std::string, or a
std::vector of some flavor.
thanks,
Tom