This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix some valgrind errors in the TUI
- From: Tom Tromey <tom at tromey dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 17 Feb 2019 08:35:02 -0700
- Subject: Re: [PATCH] Fix some valgrind errors in the TUI
- References: <20190212194621.13988-1-tom@tromey.com>
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> The styling series introduced some new errors in the TUI -- the series
Tom> changed how source lines are allocated, without updating
Tom> tui_set_source_content_nil.
Tom> There are several failures but a typical one looks like:
Tom> ==6274== Use of uninitialised value of size 8
Tom> ==6274== at 0x4E4A095: wclrtoeol (in /usr/lib64/libncursesw.so.6.1)
Tom> ==6274== by 0x4E47617: waddch (in /usr/lib64/libncursesw.so.6.1)
Tom> ==6274== by 0x8325CB: tui_puts_internal(_win_st*, char const*, int*) (tui-io.c:393)
Tom> ==6274== by 0x82E89D: tui_file::puts(char const*) (tui-file.c:39)
Tom> ==6274== by 0x84BF5F: vfprintf_unfiltered(ui_file*, char const*, __va_list_tag*) (utils.c:2026)
Tom> This patch rewrites tui_set_source_content_nil, fixing the bug.
I'm going to check this in, to unblock the release.
Tom