Re: [PATCH 2/4] Define gdb.Value(bufobj, type) constructor

[Tom Tromey <tom at tromey dot com>]

>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

>> However, this seems like a decision to make consciously.
>> I'm not completely sure how to proceed, though one idea might be to find
>> the most recent Python 2.[456] compatibility patch and then asking the
>> author whether this support is still relevant.

Kevin> I didn't know of that compatibility patch, though I'll try to track it
Kevin> down.  (A pointer would be appreciated if you have one handy.)

I just recall it happening from time to time.  Using:

    git log --grep 'Python 2\.[4-6]'

... shows a couple maybe uninteresting patches, followed by:

commit 49840f2a6669ae2366c522da41edf615785b3626
Author: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Date:   Sun Mar 16 15:01:24 2014 +0100

    Fix Python 2.4 build break
    
    This fixes a build failure against Python 2.4 by casting away "const"
    on the second argument to PyObject_GetAttrString.  Similar casts to
    support Python 2.4 were already present in a number of other places.
    
    gdb/
    2014-03-16  Ulrich Weigand  <uweigand@de.ibm.com>
    
            * python/py-value.c (get_field_flag): Cast flag_name argument to
            PyObject_GetAttrString to support Python 2.4.

So, I've CC'd Ulrich.

Tom