This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix error message and use-after-free on errors in nested source files
On 2019-02-19 6:51 p.m., Kevin Buettner wrote:
> On Tue, 19 Feb 2019 23:24:01 +0000
> Simon Marchi <simon.marchi@ericsson.com> wrote:
>
>>> Did you mean to remove gdb_exit above? If so, why?
>>
>> Yes, many tests have a gdb_exit at the end. I believe this is not necessary (though it doesn't hurt)
>> because it's done anyway after the execution of the test. So it has become an automatism to remove
>> it if I am modifying that area of the tests. I can leave it there if you prefer.
>
> Thanks for the explanation.
>
>> Thanks for the review, here's the updated version. I also fixed the title,
>> where it should read "sourced" instead of "source".
>
> LGTM.
>
> Kevin
>
Thanks, I pushed it.
Simon