This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Fix coff_start_symtab resource leak found by Coverity
- From: Gary Benson <gbenson at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 22 Feb 2019 15:13:13 +0000
- Subject: [PATCH] Fix coff_start_symtab resource leak found by Coverity
Hi all,
This commit fixes a resource leak found by Coverity, where
coff_start_symtab performs an xstrdup that is now performed
within start_symtab by buildsym_compunit::buildsym_compunit.
Built and regtested on RHEL 7.6 x86_64.
Ok to commit?
Thanks,
Gary
--
gdb/ChangeLog:
* coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
---
gdb/ChangeLog | 4 ++++
gdb/coffread.c | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/coffread.c b/gdb/coffread.c
index 6381cd3..91a112e 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -385,10 +385,7 @@ coff_start_symtab (struct objfile *objfile, const char *name)
{
within_function = 0;
start_symtab (objfile,
- /* We fill in the filename later. start_symtab puts this pointer
- into last_source_file and we put it in subfiles->name, which
- end_symtab frees; that's why it must be malloc'd. */
- xstrdup (name),
+ name,
/* We never know the directory name for COFF. */
NULL,
/* The start address is irrelevant, since we call
--
1.8.3.1