This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] gdb: Handle alignment for C++ structures with static members

From: Tom Tromey <tromey at adacore dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at adacore dot com>
Date: Mon, 25 Feb 2019 07:10:45 -0700
Subject: Re: [PATCH 2/2] gdb: Handle alignment for C++ structures with static members
References: <cover.1550874337.git.andrew.burgess@embecosm.com> <cover.1550874337.git.andrew.burgess@embecosm.com> <f21fcf7ffad97ce771101701812ed4ca69fc7af0.1550874337.git.andrew.burgess@embecosm.com>

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> 	* gdbtypes.c (type_align): Don't consider static members when
Andrew> 	computing structure alignment.

Thank you.

Andrew> +	    if (TYPE_FIELD_LOC_KIND (type, i) == FIELD_LOC_KIND_BITPOS)

This should probably use field_is_static instead.

Tom

References:
- [PATCH 0/2] Changes in type_align
  - From: Andrew Burgess
- [PATCH 2/2] gdb: Handle alignment for C++ structures with static members
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]