This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 10/13] Split rank_one_type_parm_complex from rank_one_type
- From: Simon Marchi <simon dot marchi at efficios dot com>
- To: gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at efficios dot com>
- Date: Wed, 27 Feb 2019 15:00:25 -0500
- Subject: [PATCH 10/13] Split rank_one_type_parm_complex from rank_one_type
- Dkim-filter: OpenDKIM Filter v2.10.3 mail.efficios.com A3D4E8082D
- References: <20190227200028.27360-1-simon.marchi@efficios.com>
gdb/ChangeLog:
* gdbtypes.c (rank_one_type_parm_complex): New function extracted
from...
(rank_one_type): ... this.
---
gdb/gdbtypes.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index f9aa14d724..3cf6ba87f7 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -4146,6 +4146,22 @@ rank_one_type_parm_float (struct type *parm, struct type *arg, struct value *val
}
}
+/* rank_one_type helper for when PARM's type code is TYPE_CODE_COMPLEX. */
+
+static struct rank
+rank_one_type_parm_complex (struct type *parm, struct type *arg, struct value *value)
+{
+ switch (TYPE_CODE (arg))
+ { /* Strictly not needed for C++, but... */
+ case TYPE_CODE_FLT:
+ return FLOAT_PROMOTION_BADNESS;
+ case TYPE_CODE_COMPLEX:
+ return EXACT_MATCH_BADNESS;
+ default:
+ return INCOMPATIBLE_TYPE_BADNESS;
+ }
+}
+
/* Compare one type (PARM) for compatibility with another (ARG).
* PARM is intended to be the parameter type of a function; and
* ARG is the supplied argument's type. This function tests if
@@ -4254,16 +4270,7 @@ rank_one_type (struct type *parm, struct type *arg, struct value *value)
case TYPE_CODE_FLT:
return rank_one_type_parm_float (parm, arg, value);
case TYPE_CODE_COMPLEX:
- switch (TYPE_CODE (arg))
- { /* Strictly not needed for C++, but... */
- case TYPE_CODE_FLT:
- return FLOAT_PROMOTION_BADNESS;
- case TYPE_CODE_COMPLEX:
- return EXACT_MATCH_BADNESS;
- default:
- return INCOMPATIBLE_TYPE_BADNESS;
- }
- break;
+ return rank_one_type_parm_complex (parm, arg, value);
case TYPE_CODE_STRUCT:
switch (TYPE_CODE (arg))
{
--
2.21.0