New ARI warning Thu Feb 28 02:11:32 UTC 2019 in gdb-8.3-branch

[GDB Administrator <gdbadmin at sourceware dot org>]

4a5
> gdb/ada-lang.c:2829: deprecated: deprecated set_value_type: Do not use deprecated set_value_type, see declaration for details
gdb/ada-lang.c:2829:	  deprecated_set_value_type (elt, saved_elt_type);
41d41
< gdb/cli/cli-cmds.c:853: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/cli/cli-cmds.c:853:  if ((editor = (char *) getenv (')) == NULL)
67a68
> gdb/common/array-view.h:252: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/common/array-view.h:252:make_array_view (U *array, size_t size) noexcept
118a120
> gdb/csky-tdep.c:2232: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/csky-tdep.c:2232:  set_gdbarch_read_pc (gdbarch, csky_read_pc);
gdb/csky-tdep.c:2232:  set_gdbarch_read_pc (gdbarch, csky_read_pc);
150a153
> gdb/dwarf-index-cache.c:118: gettext: trailing new line: A message should not have a trailing new line
gdb/dwarf-index-cache.c:118:	  warning (_("index cache: could not make cache directory: %s\n"),
270a274,275
> gdb/inferior.c:335: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings.  Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB
gdb/inferior.c:335:  for (inferior *inf ATTRIBUTE_UNUSED : all_non_exited_inferiors ())
> gdb/inferior.c:352: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings.  Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB
gdb/inferior.c:352:      for (thread_info *tp ATTRIBUTE_UNUSED : inf->non_exited_threads ())
290,291d294
< gdb/linespec.c:1239: code: OP eol: Do not use &&, or || at the end of a line
gdb/linespec.c:1239:	  if (startswith (method_name, ') ||
< gdb/linespec.c:1240: code: OP eol: Do not use &&, or || at the end of a line
gdb/linespec.c:1240:	      startswith (method_name, ') ||
319a323
> gdb/mi/mi-interp.c:963: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings.  Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB
gdb/mi/mi-interp.c:963:  for (inferior *inf ATTRIBUTE_UNUSED : all_non_exited_inferiors ())
390a395,401
> gdb/ppc-linux-tdep.c:1065: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1065:      if (regcache == NULL ||
> gdb/ppc-linux-tdep.c:1100: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1100:      if (regcache == NULL ||
> gdb/ppc-linux-tdep.c:1110: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1110:      if (regcache == NULL ||
> gdb/ppc-linux-tdep.c:1125: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1125:      if (regcache == NULL ||
> gdb/ppc-linux-tdep.c:1136: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1136:      if (regcache == NULL ||
> gdb/ppc-linux-tdep.c:1146: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1146:      if (regcache == NULL ||
> gdb/ppc-linux-tdep.c:1156: code: OP eol: Do not use &&, or || at the end of a line
gdb/ppc-linux-tdep.c:1156:      if ( regcache == NULL ||
392d402
< gdb/printcmd.c:1296: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/printcmd.c:1296:    if (obj_section_addr (osect) <= sect_addr	&& sect_addr < obj_section_endaddr (osect)	&& (msymbol	    = lookup_minimal_symbol_by_pc_section (sect_addr, osect).minsym))
395,438d404
< gdb/procfs.c:458: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:458:  if ((pi = find_procinfo (pid, tid)))
< gdb/procfs.c:478: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:478:      sprintf (pi->pathname, MAIN_PROC_NAME_FMT, pid);
< gdb/procfs.c:484: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:484:      sprintf (pi->pathname, ', pid, tid);
< gdb/procfs.c:575: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:575:      sprintf (procfile, ', pi->pid);
< gdb/procfs.c:620: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:620:  sprintf (errmsg, ', func, line, pi->pathname);
< gdb/procfs.c:627: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:627:  sprintf (errmsg, ', func, line, pi->pathname);
< gdb/procfs.c:641: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:641:  if (pi->status_fd == 0 &&
< gdb/procfs.c:883: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:883:  if (pi->ctl_fd == 0 &&
< gdb/procfs.c:949: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:949:  if (pi->ctl_fd == 0 &&
< gdb/procfs.c:1510: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:1510:  if (pi->ctl_fd == 0 &&
< gdb/procfs.c:1592: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/procfs.c:1592:proc_get_LDT_entry (procinfo *pi, int key)
< gdb/procfs.c:1603: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:1603:  sprintf (pathname, ', pi->pid);
< gdb/procfs.c:1615: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:1615:      if (ldt_entry->sel == 0 &&
< gdb/procfs.c:1616: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:1616:	  ldt_entry->bo  == 0 &&
< gdb/procfs.c:1617: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:1617:	  ldt_entry->acc1 == 0 &&
< gdb/procfs.c:1631: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/procfs.c:1631:procfs_find_LDT_entry (ptid_t ptid)
< gdb/procfs.c:1638: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1638:  if ((pi = find_procinfo (ptid.pid (), ptid.lwp ())) == NULL)
< gdb/procfs.c:1645: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1645:  if ((gregs = proc_get_gregs (pi)) == NULL)
< gdb/procfs.c:1760: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1760:	if ((thread = create_procinfo (pi->pid, lwpid)) == NULL)
< gdb/procfs.c:1799: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1799:      if ((retval = (*func) (pi, thread, ptr)) != 0)
< gdb/procfs.c:1943: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1943:  if ((pi = create_procinfo (ptid.pid (), 0)) == NULL)
< gdb/procfs.c:1949: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:1949:      sprintf (errmsg, ',
< gdb/procfs.c:1986: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:1986:  if ((fail = procfs_debug_inferior (pi)) != 0)
< gdb/procfs.c:2229: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2229:      if (!(proc_flags (pi) & (PR_STOPPED | PR_ISTOP)) &&
< gdb/procfs.c:2354: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2354:		    if ((nsysargs = proc_nsysarg (pi)) > 0 &&
< gdb/procfs.c:2355: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:2355:		    if ((nsysargs = proc_nsysarg (pi)) > 0 &&			(sysargs  = proc_sysargs (pi)) != NULL)
< gdb/procfs.c:2438: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2438:		    if ((nsysargs = proc_nsysarg (pi)) > 0 &&
< gdb/procfs.c:2439: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:2439:		    if ((nsysargs = proc_nsysarg (pi)) > 0 &&			(sysargs  = proc_sysargs (pi)) != NULL)
< gdb/procfs.c:2527: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2527:	      if (retval.pid () > 0 &&
< gdb/procfs.c:2528: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2528:		  retval != inferior_ptid &&
< gdb/procfs.c:2595: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2595:  if (pi->as_fd == 0 &&
< gdb/procfs.c:2644: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2644:    if (parent == NULL ||
< gdb/procfs.c:2651: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2651:      if (parent == NULL ||
< gdb/procfs.c:2737: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2737:  if (signo == 0 ||
< gdb/procfs.c:2904: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:2904:  if ((pi = create_procinfo (pid, 0)) == NULL)
< gdb/procfs.c:2923: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:2923:  if (!(proc_flags (pi) & PR_STOPPED) &&
< gdb/procfs.c:2941: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:2941:  if ((fail = procfs_debug_inferior (pi)) != 0)
< gdb/procfs.c:2986: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:2986:  if ((pi = create_procinfo (getpid (), 0)) == NULL)
< gdb/procfs.c:3183: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:3183:  if ((pi = find_procinfo (proc, thread)) == NULL)
< gdb/procfs.c:3207: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:3207:    sprintf (buf, ', ptid.pid ());
< gdb/procfs.c:3209: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:3209:    sprintf (buf, ', ptid.lwp ());
< gdb/procfs.c:3402: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/procfs.c:3402:  sprintf (pathname, ', pi->pid);
< gdb/procfs.c:3420: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/procfs.c:3420:    if ((funcstat = (*func) (prmap, child_func, data)) != 0)
< gdb/procfs.c:3864: code: OP eol: Do not use &&, or || at the end of a line
gdb/procfs.c:3864:      if (inf_args && *inf_args &&
471a438,439
> gdb/rs6000-aix-tdep.c:92: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-aix-tdep.c:92:      func = read_memory_unsigned_integer (base_orig +
> gdb/rs6000-aix-tdep.c:101: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-aix-tdep.c:101:      func = read_memory_unsigned_integer (base_orig +
500,517c468,469
< gdb/rs6000-tdep.c:2624: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2624:	status = regcache->raw_read (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2643: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2643:      regcache->raw_write (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2645: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2645:      regcache->raw_write (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2650: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2650:      regcache->raw_write (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2652: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2652:      regcache->raw_write (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2668: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2668:    status = regcache->raw_read (tdep->ppc_vr0_regnum +
< gdb/rs6000-tdep.c:2674: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2674:	status = regcache->raw_read (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2677: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2677:	  status = regcache->raw_read (tdep->ppc_vsr0_upper_regnum +
< gdb/rs6000-tdep.c:2682: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2682:	status = regcache->raw_read (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2685: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2685:	  status = regcache->raw_read (tdep->ppc_vsr0_upper_regnum +
< gdb/rs6000-tdep.c:2702: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2702:    regcache->raw_write (tdep->ppc_vr0_regnum +
< gdb/rs6000-tdep.c:2708: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2708:	regcache->raw_write (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2710: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2710:	regcache->raw_write (tdep->ppc_vsr0_upper_regnum +
< gdb/rs6000-tdep.c:2715: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2715:	regcache->raw_write (tdep->ppc_fp0_regnum +
< gdb/rs6000-tdep.c:2717: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:2717:	regcache->raw_write (tdep->ppc_vsr0_upper_regnum +
< gdb/rs6000-tdep.c:5773: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:5773:					   tdep->ppc_gp0_regnum +
< gdb/rs6000-tdep.c:5837: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:5837:  from_xcoff_exec = info.abfd && info.abfd->format == bfd_object &&
< gdb/rs6000-tdep.c:5840: code: OP eol: Do not use &&, or || at the end of a line
gdb/rs6000-tdep.c:5840:  from_elf_exec = info.abfd && info.abfd->format == bfd_object &&
> gdb/rust-exp.y:23: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/rust-exp.y:23:%pure-parser
> gdb/rust-exp.y:25: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
gdb/rust-exp.y:25:%parse-param {struct rust_parser *parser}
518a471,473
> gdb/s12z-tdep.c:92: gettext: trailing new line: A message should not have a trailing new line
gdb/s12z-tdep.c:92:  warning (_("%s Failed to find end of prologue PC = %08x\n"),
> gdb/s12z-tdep.c:93: regression: __FUNCTION__: Do not use __FUNCTION__, ISO C 90 does not support this macro
gdb/s12z-tdep.c:93:                      __FUNCTION__, (unsigned int) pc);
> gdb/s12z-tdep.c:214: gettext: trailing new line: A message should not have a trailing new line
gdb/s12z-tdep.c:214:      warning (_("Couldn't find function including address %s SP is %s\n"),
533,535d487
< gdb/sol-thread.c:710: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/sol-thread.c:710:      if ((val = p_td_thr_validate (&th)) != TD_OK)
< gdb/sol-thread.c:973: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/sol-thread.c:973:ps_lgetLDT (struct ps_prochandle *ph, lwpid_t lwpid,	    struct ssd *pldt)
< gdb/sol-thread.c:1197: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/sol-thread.c:1197:#define resolve(X)   if (!(p_##X = (X ## _ftype *) dlsym (dlhandle, #X)))
572a525,526
> gdb/thread-iter.c:30: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/thread-iter.c:30:    if ((m_thr = m_inf->thread_list) != NULL)
> gdb/thread.c:581: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings.  Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB
gdb/thread.c:581:  for (thread_info *tp ATTRIBUTE_UNUSED : all_threads ())
600d553
< gdb/tracepoint.c:1187: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tracepoint.c:1187:      sprintf (end, ', m_aexprs[i]->len);
615,617d567
< gdb/tui/tui-source.c:132: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-source.c:132:		      sprintf (src_line, ', cur_line_no);
< gdb/tui/tui-source.c:207: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/tui/tui-source.c:207:				  if (c == '.' 				      && (c = fgetc (stream)) != '.' 				      && c != EOF)
< gdb/tui/tui-source.c:305: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-source.c:305:	  sprintf (src_line + i, ', warning_string);
664d613
< gdb/utils.c:2978: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/utils.c:2978:      sprintf (retp, ', *p);
679,680d627
< gdb/valops.c:2005: code: OP eol: Do not use &&, or || at the end of a line
gdb/valops.c:2005:	  startswith (t_field_name, ') ||
< gdb/valops.c:3750: code: OP eol: Do not use &&, or || at the end of a line
gdb/valops.c:3750:  new_val = value_at_lazy (real_type, value_address (argp) - top +