Re: [PATCH 00/16] Add styling to the gdb CLI and TUI

[Eli Zaretskii <eliz at gnu dot org>]

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
> Date: Thu, 29 Nov 2018 15:43:59 -0700
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> Will the Windows TUI build support styling out of the box?  It uses
> Eli> ncurses.
> 
> I think it should work, but you'd have to "set style enabled on" first.

For the record, it doesn't work in GDB 8.2.90, even after I disabled
the test for $TERM being defined in the environment.  I will try to
find out why at some point.

> I think either utils.c would have to be modified to change where it
> sends output, or stdio_file::puts would have to be modified.  The idea
> there would be to call a host-specific function; and then on Windows do
> the filtering+styling if the output is going to the terminal.

I'm looking into this now.  The simplest change would be to modify
stdio_file::puts that performs the filtering only on Windows, but the
fact that you mentioned calling a host-specific function confuses me a
little.  Can you elaborate on what you had in mind, and specifically
what kind of a host-specific function should be involved here, and
how?

Thanks.