This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case)

On Monday, March 04 2019, Simon Marchi wrote:

> On 2019-03-04 12:49, Sergio Durigan Junior wrote:
>> On commit 8ecfd7bd4acd69213c06fac6de9af38299123547 ("Add parameter to
>> allow enabling/disabling selftests via configure") it seems that I
>> forgot to use the proper '$enable_unittest' variable when checking to
>> see whether to add selftest-related objects to 'srv_regobj'.  This
>> causes a build failure on Aarch64 when 'development=false' (which is
>> the case for the 8.3 branch) and 'enable_unittest=true'.
>>
>> This patch fixes the problem by using '$enable_unittest' instead of
>> '$development' when performing the check.  As a reminder, it's
>> important to notice that '$enable_unittest's default value (i.e., when
>> the option '--enable-unit-tests' is not passed to configure) is the
>> same as '$development', so this patch doesn't affect the current
>> build.
>>
>> I'd like to install this patch both on master and on the 8.3 branch.
>>
>> OK?
>
> Thanks, this LGTM.

Thanks, pushed.

45950eb60008c70fb79306012e76a024a8790ca3

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]