This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 05 Mar 2019 12:32:40 -0700
Subject: Re: [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid
References: <20190305184340.26768-1-palves@redhat.com> <20190305184340.26768-2-palves@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> In the
Pedro> multi-target branch, I'm forcing inferior_ptid to null_ptid early in
Pedro> infrun event handling to make sure we inadvertently rely on the
Pedro> current thread/target when we shouldn't, and that caught some bad
Pedro> or unnecessary assumptions throughout.

This read a bit strangely to me.  Maybe instead write "to make sure we
don't inadvertently rely on the current thread/target,..."?

The patch itself seemed fine to me.  Big +1 to reducing the impact of
globals.

Tom

Follow-Ups:
- Re: [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid
  - From: Pedro Alves

References:
- [PATCH 0/4] Make "checkpoint" not rely on inferior_ptid
  - From: Pedro Alves
- [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]