This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Make "checkpoint" not rely on inferior_ptid
On 03/05/2019 07:32 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> In the
> Pedro> multi-target branch, I'm forcing inferior_ptid to null_ptid early in
> Pedro> infrun event handling to make sure we inadvertently rely on the
> Pedro> current thread/target when we shouldn't, and that caught some bad
> Pedro> or unnecessary assumptions throughout.
>
> This read a bit strangely to me. Maybe instead write "to make sure we
> don't inadvertently rely on the current thread/target,..."?
>
Oh, yes, I missed typing the "don't". Thanks for spotting that.
> The patch itself seemed fine to me. Big +1 to reducing the impact of
> globals.
Thanks,
Pedro Alves