This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/5] Introduce target_ops method thread_info_to_thread_handle
- From: Tom Tromey <tom at tromey dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 05 Mar 2019 14:44:05 -0700
- Subject: Re: [PATCH v2 1/5] Introduce target_ops method thread_info_to_thread_handle
- References: <20190227192416.613752c8@f29-4.lan> <20190227193025.3a6750ed@f29-4.lan>
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> +gdb::byte_vector
Kevin> +target_thread_info_to_thread_handle (struct thread_info *tip)
Kevin> +{
Kevin> + return current_top_target ()->thread_info_to_thread_handle (tip);
Kevin> +}
It's the gdb style to stick /* See target.h. */ before the definition.
Kevin> + virtual gdb::byte_vector thread_info_to_thread_handle (struct thread_info *)
Kevin> + TARGET_DEFAULT_RETURN (gdb::byte_vector ());
This should probably have a comment explaining what is meant by the
return value.
Kevin> +/* Given a thread, return the thread handle. */
Kevin> +extern gdb::byte_vector target_thread_info_to_thread_handle
Kevin> + (struct thread_info *);
Explaining that the thread handle is just some target-specific bytes
would be good.
Tom