This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Apply substitute-path to relative filenames as well


>>>>> "LRN" == LRN  <lrn1986@gmail.com> writes:

LRN> The patch is attached.
LRN> The change itself is similar to
LRN> https://www.sourceware.org/ml/gdb-patches/2017-02/msg00693.html , but the code
LRN> is slightly cleaner (at the cost of making the patch larger).

Thank you for the patch.

LRN> Also, as the patch is trivial, so i would expect it to not to require copyright
LRN> assignment (i do have one, but David Grayson might not have).

I agree.

LRN> 2019-02-28 Руслан Ижбулатов  <lrn1986@gmail.com>

LRN>        * source.c (find_and_open_source): Apply substitute-path to all
LRN>        filenames, both absolute and relative

Is it possible to get a test case for the patch?

LRN>    gdb::unique_xmalloc_ptr<char> rewritten_filename;
[...]
LRN> +  rewritten_filename = rewrite_source_path (filename);

I think these two lines can now be joined; no need to have a separate
assignment.

thanks,
Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]