This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 01/22] Remove cleanups from coffread.c


On 02/27/2019 08:18 PM, Tom Tromey wrote:
> This removes the remaining cleanups from coffread.c.
> 
> Tested by the buildbot.  However, I don't think the buildbot really
> tests these code paths, and TBH I am not sure how to do it manually.
> I did manage to crash an earlier version of the patch using a mingw
> .exe file, though I would have thought that was only going to test
> coff-pe-read.c.

PE files are coff files with extra sauce.  coff-pe-read.c only takes
care of the PE export tables (extra sauce).

> @@ -701,7 +691,7 @@ coff_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
>    if (!(objfile->flags & OBJF_READNEVER))
>      bfd_map_over_sections (abfd, coff_locate_sections, (void *) info);
>  
> -  if (info->stabsects)
> +  if (! info->stabsects->empty())

No space after '!'.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]