This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 04/22] C++ify remote notification code
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 06 Mar 2019 14:12:42 -0700
- Subject: Re: [PATCH v2 04/22] C++ify remote notification code
- References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-5-tom@tromey.com> <6f911dfb-3018-33b0-fbb1-48ece1607c1e@redhat.com>
>> + std::unique_ptr<struct notif_event> event = nc->alloc_event ();
Pedro> "std::unique_ptr<struct notif_event>" appears in a number of places
Pedro> in the patch. Did you consider adding a "notif_event_up" typedef ?
Nope, but I've added it now.
>> -typedef std::unique_ptr<stop_reply, stop_reply_deleter> stop_reply_up;
>> +typedef std::unique_ptr<struct stop_reply> stop_reply_up;
Pedro> Odd that you added the "struct". I tend to remove it when touching
Pedro> code instead. :-)
I changed this back.
Tom