This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 11/22] Use unique_xmalloc_ptr in remote.c
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 6 Mar 2019 21:16:55 +0000
- Subject: Re: [PATCH v2 11/22] Use unique_xmalloc_ptr in remote.c
- References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-12-tom@tromey.com>
On 02/27/2019 08:18 PM, Tom Tromey wrote:
> This removes a cleanup from remote.c, replacing it with
> unique_xmalloc_ptr.
>
> gdb/ChangeLog
> 2019-02-27 Tom Tromey <tom@tromey.com>
>
> * remote.c (remote_target::remote_parse_stop_reply): Use
> unique_xmalloc_ptr.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/remote.c | 11 +++++------
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/remote.c b/gdb/remote.c
> index f80dcdaee94..5f658deefaa 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -7314,14 +7314,13 @@ Packet: '%s'\n"),
>
> /* Save the pathname for event reporting and for
> the next run command. */
> - char *pathname = (char *) xmalloc (pathlen + 1);
> - struct cleanup *old_chain = make_cleanup (xfree, pathname);
> - hex2bin (p1, (gdb_byte *) pathname, pathlen);
> - pathname[pathlen] = '\0';
> - discard_cleanups (old_chain);
> + gdb::unique_xmalloc_ptr<char> pathname
> + ((char *) xmalloc (pathlen + 1));
Use:
gdb::unique_xmalloc_ptr<char[]>
> + hex2bin (p1, (gdb_byte *) pathname.get (), pathlen);
> + pathname.get ()[pathlen] = '\0';
Then here write:
pathname[pathlen] = '\0';
Otherwise OK.
Thanks,
Pedro Alves