This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 6 Mar 2019 22:00:40 +0000
- Subject: Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file
- References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-22-tom@tromey.com>
On 02/27/2019 08:18 PM, Tom Tromey wrote:
> This replaces a try/catch in write_gcore_file with a use of SCOPE_EXIT
> instead. I find that this is simpler to understand.
>
> gdb/ChangeLog
> 2019-02-27 Tom Tromey <tom@tromey.com>
>
> * gcore.c (write_gcore_file): Use SCOPE_EXIT.
You could rebase this on current master and push it in, to get it
out of the way.
You could also merge patches #1-#13, the cleanup-elimination patches
until the TRY/CATCH parts. I'll need a bit more time to comment
on those TRY/CATCH parts, so I've skipped them tonight.
Thanks,
Pedro Alves