This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 6 Mar 2019 22:54:01 +0000
- Subject: Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file
- References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-22-tom@tromey.com> <fa5fe6e6-2cdb-cad4-9bfd-cb8ffda7f096@redhat.com> <87bm2nljnr.fsf@tromey.com>
--
Thanks,
Pedro Alves
On 03/06/2019 10:31 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> You could rebase this on current master and push it in, to get it
> Pedro> out of the way.
>
> Unless there's a need, I'd rather leave it as-is, since rebasing it
> earlier means tweaking other patches earlier in the series.
The only tweak othe other patches would need would be to not touch
the file at all. This patch eliminates the need for any of the
previous changes to the same code.
>
> Pedro> You could also merge patches #1-#13, the cleanup-elimination patches
> Pedro> until the TRY/CATCH parts. I'll need a bit more time to comment
> Pedro> on those TRY/CATCH parts, so I've skipped them tonight.
>
> I don't mind waiting, it's not a super rush to get this in.
> Thanks for looking through these.
I'd think getting the cleanups elimination patches in would be
good for the fact that it makes it impossible for anyone else to
end up adding new cleanups meanwhile. And, it makes the remainder
patches a smaller self-contained series; any new repost would be
much smaller.
Thanks,
Pedro Alves