This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 8.3 0/3] Some style fixes
- From: "Hannes Domani via gdb-patches" <gdb-patches at sourceware dot org>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Sat, 9 Mar 2019 14:28:18 +0000 (UTC)
- Subject: Re: [RFC 8.3 0/3] Some style fixes
- References: <20190308210433.32683-1-tromey@adacore.com>
- Reply-to: Hannes Domani <ssbssa at yahoo dot de>
Am Freitag, 8. März 2019, 22:04:47 MEZ hat Tom Tromey <tromey@adacore.com> Folgendes geschrieben:
> This series fixes some of the TUI/styling regressions noted by Pedro.
> I would like to push this to the 8.3 branch as well.
>
> Patch #2 is a new feature that Eli mentioned. Since it's an addition
> to a feature that is also new in 8.3, it seemed reasonable to do at
> this time.
>
> Let me know what you think.
These patches work great for me.
But while testing them I saw some weird behavior which was introduced with the style patches.
1) Outside of TUI, escaped characters (< 040 and 0177) aren't handled correctly any more when
list'ing some source code, resulting in an endless loop.
See print_source_lines_base(), I just added "++iter" in the last 2 if() blocks, that fixed it for me.
2) In TUI, scrolling right with the arrow keys, the first keypress doesn't do anything.
(that's just a very minor nuisance)
3) Again in TUI, scrolling right handles TABS and escaped characters as single characters,
which just looks weird.
Regards
Hannes Domani