This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MinGW build failure for GDB 8.2.90 with source-highlight
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>
- Date: Mon, 11 Mar 2019 22:31:17 -0400
- Subject: Re: MinGW build failure for GDB 8.2.90 with source-highlight
- References: <83r2bibvlv.fsf@gnu.org> <83ef7d5wak.fsf@gnu.org>
On 2019-03-11 10:18, Eli Zaretskii wrote:
Ping! This discussion seems to have stalled. I'd like to have it
solved before GDB 8.3 is released.
Agreed, this is definitely a blocker for the release. I recorded it
here:
https://www.sourceware.org/gdb/wiki/GDB_8.3_Release
If no better ideas come up, I'd like to commit the change described
here:
Perhaps we should simply #undef these two symbols before including
<fstream>?
TIA
If the change is localized in one or a handful of files, I think it
would be acceptable for the 8.3 release, since the alternative solution
would be (1) a lot of work and (2) risky.
Can you post a patch that fixes the build for you?
Pedro, did you have a branch where you put all of gdb in the gdb
namespace? I only found this branch, but it's using the gnulib::
namespace, which is not the same.
https://github.com/palves/gdb/commits/palves/cxx-gnulib-namespace
I just started to try to do it to get a feel of what's needed. I guess
we need to put pretty much everything except includes (and maybe some
other rare exceptions) between namespace gdb { ... }? And of course
define GNULIB_NAMESPACE to gdb.
Simon