This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH v2 00/11] Support for thread-local variables on FreeBSD


On 2019-02-22 12:21 p.m., John Baldwin wrote:
On 2/8/19 4:40 PM, John Baldwin wrote:
Relative to the first version the changes are:

- Patch 2 fixes some #ifdef's pointed by Simon in amd64-bsd-nat.c.
- Patch 3's description has been reworked to narrow down the cases in
   which it applies.
- Patch 5 is a new cleanup patch
- Patch 6 is a new patch that introduces a new method to lookup the
   offset of a field in a structure.  It is slightly more general than
   just returning offsets so that it can hopefully be used to replace
   the lk_find_field function in the Linux kernel patchset.
- Patch 7 (formerly 5) now uses the new method from Patch 6 to lookup
   the offsets of two fields in a runtime linker structure instead of
   parse_and_eval_long with manual offsetof.

John Baldwin (11):
   Support the fs_base and gs_base registers on i386.
   Support fs_base and gs_base on FreeBSD/i386.
   Handle an edge case for minisym TLS variable lookups.
   Add a new gdbarch method to resolve the address of TLS variables.
   Remove code disabled since at least 1999 from lookup_struct_elt_type.
   Add a more general version of lookup_struct_elt_type.
   Add a helper function to resolve TLS variable addresses for FreeBSD.
   Support TLS variables on FreeBSD/amd64.
   Support TLS variables on FreeBSD/i386.
   Support TLS variables on FreeBSD/riscv.
   Support TLS variables on FreeBSD/powerpc.

I'll probably wait until the 8.3 branch if this is OK'd.  Simon looked at
the first 3 patches previously (though 3 has a new description since the
first series).  Andrew ok'd the FreeBSD/riscv patch as well.  The
FreeBSD-specific ones are probably ok, but patches 4-6 probably could use
at least some looking over.

Hi John,

Since nobody else answered to patch 4, I am fine with you pushing the series, we should have plenty of time before the next release to fix any problem.

Thanks,

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]