This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] gdb: unconditionally define _initialize_string_view_selftests
- From: Sergei Trofimovich <slyfox at gentoo dot org>
- To: gdb-patches at sourceware dot org
- Cc: Sergei Trofimovich <slyfox at gentoo dot org>
- Date: Thu, 14 Mar 2019 22:28:28 +0000
- Subject: [PATCH] gdb: unconditionally define _initialize_string_view_selftests
The build failure was noticed by Helmut Jarausch in
https://bugs.gentoo.org/680232:
$ ./configure CXXFLAGS='-std=c++17 -Os'
...
CXXLD gdb
ld: init.o: in function `initialize_all_files()':
init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()'
It happens because '_initialize_string_view_selftests()' is
conditionally defined based on C++ default.
The change defines '_initialize_string_view_selftests()'
unconditionally and leaves implementation a no-op on c++17
compilers.
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
gdb/unittests/string_view-selftests.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gdb/unittests/string_view-selftests.c b/gdb/unittests/string_view-selftests.c
index 21a10e65af..b2a2bf7f2e 100644
--- a/gdb/unittests/string_view-selftests.c
+++ b/gdb/unittests/string_view-selftests.c
@@ -170,10 +170,12 @@ run_tests ()
} /* namespace string_view */
} /* namespace selftests */
+#endif /* __cplusplus < 201703L */
+
void
_initialize_string_view_selftests ()
{
+#if defined(GDB_STRING_VIEW)
selftests::register_test ("string_view", selftests::string_view::run_tests);
+#endif
}
-
-#endif /* __cplusplus < 201703L */
--
2.21.0