This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/configure.ac: add --enable-source-highlight
- From: Tom Tromey <tom at tromey dot com>
- To: Sergei Trofimovich <slyfox at gentoo dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 Mar 2019 08:18:42 -0600
- Subject: Re: [PATCH] gdb/configure.ac: add --enable-source-highlight
- References: <20190313215020.11959-1-slyfox@gentoo.org>
>>>>> "Sergei" == Sergei Trofimovich <slyfox@gentoo.org> writes:
Sergei> Allow disabling source-highlight dependency autodetection even
Sergei> it exists in the system. More details on problem of automatic
Sergei> dependencies:
Sergei> https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies
Sergei> Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238
Hi. Thank you for the patch.
This looks essentially fine to me. Do you have a copyright assignment
in place? (Though I wonder whether one is really needed, given that the
actual change here is pretty small.)
This probably could use some minor follow-on patches, e.g. for "show
configuration", but I'm happy to do those.
Tom