This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb/configure.ac: add --enable-source-highlight


>>>>> "Sergei" == Sergei Trofimovich <slyfox@gentoo.org> writes:

Sergei> Allow disabling source-highlight dependency autodetection even
Sergei> it exists in the system. More details on problem of automatic
Sergei> dependencies:
Sergei> https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies

Sergei> Noticed by Jeroen Roovers in https://bugs.gentoo.org/680238

Hi.  Thank you for the patch.

This looks essentially fine to me.  Do you have a copyright assignment
in place?  (Though I wonder whether one is really needed, given that the
actual change here is pretty small.)

This probably could use some minor follow-on patches, e.g. for "show
configuration", but I'm happy to do those.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]