Re: [PATCH] Improve/fix the TUI's current source line highlight

[Eli Zaretskii <eliz at gnu dot org>]

> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 14 Mar 2019 17:35:57 +0000
> 
> This patch changes that to something that I find much more sensible --
> only reverse the default foreground/background colors, leave styled
> text colors alone.  If the foreground color is not the default (because the
> text was styled), leave the foreground color as is.  If
> e.g., the terminal is fg=BLACK, and bg=WHITE, and the style wants to
> print text in RED, reverse the background color (print in BLACK), but
> still print the text in RED.
> 
> I've attached screenshots of before/after patch, with both
> white-on-black (actually, linux-colors / grey-ish-on-black),
> and black-on-white themes in my console (konsole).  Also attached
> screenshots with styling disabled, so that you can see how the
> after-patch versions look more like the unstyled output.
> 
> Note: The new ui_file_style::set_fg method isn't called set_foreground
> instead, because set_foreground is a macro in /usr/lib/term.h (ncurses).
> 
> WDYT?  
> 
> Eli, could you try this on Windows, see if it behaves as intended there?

Tested on MS-Windows, works fine.  I think you should push this.

Thanks.