This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][PR gdb/24351] Fix wrong format specification in display_selector()

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Владимир Мартьянов <vilgeforce at gmail dot com>
Cc: gdb-patches at sourceware dot org
Date: Sun, 17 Mar 2019 14:44:54 -0400
Subject: Re: [PATCH][PR gdb/24351] Fix wrong format specification in display_selector()
References: <CAL5iTPLqaE5gA+DpcjsBYVjV7e-xuTZHkag1YOnSZbC8Z_+dXg@mail.gmail.com>

On 2019-03-17 05:48, Владимир Мартьянов wrote:

There are a wrong format strings in function display_selector() in
file windows-nat.c. This leads to build error using Cygwin on Windows.
LDT_ENTRY.HighWord is a DWORD, which is unsigned long int, so the
format specification should be for long int, not simply int.

gdb/ChangeLog:
2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>

    PR gdb/24351
    * windows-nat.c (display_selector): Format specifications fixed

Patch and changelog files are attached

Thanks, this LGTM. I altavista'ed and it looks like this is the rightthing to do to print DWORDs. It also builds fine withi686-w64-mingw32-gcc and x86_64-w64-mingw32-gcc on Linux.


I tweaked the ChangeLog entry a bit and pushed it.

Simon

Follow-Ups:
- Re: [PATCH][PR gdb/24351] Fix wrong format specification in display_selector()
  - From: Jon Turney

References:
- [PATCH][PR gdb/24351] Fix wrong format specification in display_selector()
  - From: Владимир Мартьянов

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]