This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/8] gdb/fortran: Handle internal function calls

From: Tom Tromey <tom at tromey dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org, Richard Bunt <Richard dot Bunt at arm dot com>
Date: Tue, 19 Mar 2019 13:52:37 -0600
Subject: Re: [PATCH 2/8] gdb/fortran: Handle internal function calls
References: <cover.1552913183.git.andrew.burgess@embecosm.com> <e8ddc573732bbbde4e92beb802b7198c6583b0b7.1552913183.git.andrew.burgess@embecosm.com>

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> If an convenience function is defined in python (or guile), then
Andrew> currently this will not work in Fortran, instead the user is given
Andrew> this message:

Thank you.  This looks good to me.  I had one nit though:

Andrew> +	      if (code == TYPE_CODE_PTR || code == TYPE_CODE_FUNC)
Andrew> +		{
Andrew> +		  bool is_artificial =
Andrew> +		    TYPE_FIELD_ARTIFICIAL (value_type (arg1), tem - 1);

gdb style is to line break before the "=", not after.

Tom

References:
- [PATCH 0/8] Series of Fortran type printing patches
  - From: Andrew Burgess
- [PATCH 2/8] gdb/fortran: Handle internal function calls
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]