This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/5] Add python method InferiorThread.thread_handle
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Wed, 20 Mar 2019 13:24:09 -0700
- Subject: Re: [PATCH v2 2/5] Add python method InferiorThread.thread_handle
- References: <20190227192416.613752c8@f29-4.lan> <20190227193107.5c55cc03@f29-4.lan> <87ef7lq9fx.fsf@tromey.com>
On Tue, 05 Mar 2019 14:48:34 -0700
Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>
> Kevin> +/* Implementation of gdb.InferiorThread.thread_handle (self) -> handle. */
>
> What would you think of just the name "handle"? The "thread" part
> seemed redundant to me.
I like this idea, though to maintain consistency, I think we should
also rename the existing Inferior.thread_from_thread_handle function
to Inferior.thread_from_handle. I'll add another commit which does
this to the upcoming v3 series which I'm working on.
Kevin