FW: [PATCH 2/2] gdbserver: Add linux_get_hwcap

[Alan Hayward <Alan dot Hayward at arm dot com>]

    (resending because mac mail forces to html format when attaching a file....)
    
    > On 26 Mar 2019, at 14:06, Simon Marchi <simark@simark.ca> wrote:
    > 
    > On 2019-03-26 9:17 a.m., Alan Hayward wrote:
    >>>> @@ -545,8 +521,8 @@ aarch64_arch_setup (void)
    >>>>    if (is_elf64)
    >>>>      {
    >>>>        uint64_t vq = aarch64_sve_get_vq (tid);
    >>>> -      unsigned long hwcap = 0;
    >>>> -      bool pauth_p = aarch64_get_hwcap (&hwcap) && (hwcap & AARCH64_HWCAP_PACA);
    >>>> +      unsigned long hwcap = linux_get_hwcap (8);
    >>>> +      bool pauth_p = hwcap & AARCH64_HWCAP_PACA;
    >>> 
    >>> Just wondering, can the linux-aarch64-low.c code be used to debug a process
    >> "gdbserver :2345 a.out” works on an AArch64 box if that’s what you're asking?
    >> The code above is used to detect point auth.
    > 
    > Oops no, half of my sentence is missing!  I meant, can this code be used to debug 32 bit processes, and if so, is linux_get_hwcap (8) right.
    > 
    
    It’s within a is_elf64 check, so should always be 8.
    
    
    >> Updated patch below. Will push if you have no more comments.
    > 
    > For some reason, I am not able to apply "updated" patches you send.  I presume that you paste it and your email client changes the formatting. Could you maybe send it as an attached file?  It's not ideal either, because it makes it difficult to reply/comment on the patch, but at least the email client won't change the formatting.
    > 
    
    Attached.

Attachment: gdbserver_hwcap.patch
Description: gdbserver_hwcap.patch