This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: FW: [PATCH 2/2] gdbserver: Add linux_get_hwcap

From: Simon Marchi <simark at simark dot ca>
To: Alan Hayward <Alan dot Hayward at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
Date: Tue, 26 Mar 2019 10:56:15 -0400
Subject: Re: FW: [PATCH 2/2] gdbserver: Add linux_get_hwcap
References: <20190325120542.92123-1-alan.hayward@arm.com> <20190325120542.92123-2-alan.hayward@arm.com> <c35bf474-2d6e-9a6b-080f-08a59bd186a3@simark.ca> <E6E2F099-C14C-4048-B9CB-0515B65CF78C@arm.com> <353e83d9-efb3-c485-9ae6-6fc0a1f54553@simark.ca> <57CEBD0C-44A5-48D1-8CEB-54584E1A1A21@arm.com> <59A457A2-F464-4A05-A471-700F066114AD@arm.com>

On 2019-03-26 10:33 a.m., Alan Hayward wrote:
> It’s within a is_elf64 check, so should always be 8.

Ah, good point.

>>> Updated patch below. Will push if you have no more comments.

It LGTM, thanks for doing this!

Simon

References:
- [PATCH 1/2] Add linux_get_hwcap
  - From: Alan Hayward
- [PATCH 2/2] gdbserver: Add linux_get_hwcap
  - From: Alan Hayward
- Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap
  - From: Simon Marchi
- Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap
  - From: Alan Hayward
- Re: [PATCH 2/2] gdbserver: Add linux_get_hwcap
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]