This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Apply substitute-path to relative filenames as well
- From: Tom Tromey <tom at tromey dot com>
- To: LRN <lrn1986 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 27 Mar 2019 15:36:53 -0600
- Subject: Re: [PATCH] Apply substitute-path to relative filenames as well
- References: <5a785bba-7432-f6e0-1089-5d2bdd3450a3@gmail.com> <871s3lq8fy.fsf@tromey.com> <5415b22f-c46c-8dbf-4481-98be267e25bb@gmail.com>
>>>>> "LRN" == LRN <lrn1986@gmail.com> writes:
>> Thank you for the patch.
LRN> Hey, it's been a week. Do i need to do something to move this along? (Please,
LRN> don't say "test case" :( )
Is it possible to write one? I didn't think about it in detail.
The norm is that a patch should come with a test case. Exceptions are
for refactoring patches, where the intent is to preserve semantics; and
for the relatively rare cases where a test is very difficult or
impossible to write.
I see there are already tests in gdb.base/subst.exp. Perhaps it could
be extended?
Also the review had a little nit that could be addressed.
thanks,
Tom