Re: [RFC/PATCH] Testsuite: set sysroot when using gdbserver

[Alan Hayward <Alan dot Hayward at arm dot com>]

> On 28 Mar 2019, at 05:14, Kevin Buettner <kevinb@redhat.com> wrote:
> 
> Hi Alan,
> 
> I want to apologize in case my latter comment came across as harsh.  I
> think I could have phrased it more diplomatically.

Oh, no, that’s fine :)

> 
> I'll note that I also have an interest in setting up sysroot for the
> OpenMP tests that I've been working on.  So I am genuinely interested
> in whether or how sysroot can be set from a board file.
> 
> Also, making the tests run faster is definitely a good thing, so
> thanks for looking into this.


I don’t know much about how the board files work, but, looks like I can
just add a flag via “set_board_info” in the relevant board files.

I can then check for it at the end of gdbserver_start. Or instead check
at the same place “target remote” is run (although I couldn’t find where
that was yesterday!).

This looks like a much better way of doing it.

I’m going to we on holiday for the next week, so I doubt I’ll be able to
get a new patch together before then.  I will look at it as soon as I get
back, as I’d like to get rid of the buildbot timeouts.

Alan.

> 
> Kevin
> 
> On Wed, 27 Mar 2019 13:49:15 -0700
> Kevin Buettner <kevinb@redhat.com> wrote:
> 
>> On Wed, 27 Mar 2019 16:40:30 +0000
>> Alan Hayward <Alan.Hayward@arm.com> wrote:
>> 
>>> However, I'm not sure if putting the sysroot into gdbserver_start will break
>>> other remote setups.  In addition, I don't think gdb_test is the correct
>>> function to call within the library - for the mi tests this causes a timeout
>>> as it expect to use mi_gdb_test.  
>> 
>> Can sysroot be set in the board file(s)?
>> 
>> If so, I think that would be preferable to your proposed patch.
>> 
>> Kevin