Re: [PATCH v4] Add gdb.Value.format_string ()

[Marco Barisione <mbarisione at undo dot io>]

On 27 Mar 2019, at 20:16, Tom Tromey <tom@tromey.com> wrote:
> I only have two nits with this patch.  The rest looks very good, thank
> you for doing this.

Thanks!

I’ve attached a patch which is identical to the previous one except for:
* Indentation fixed;
* The NEWS file update was moved to the “Since GDB 8.3” section;
* Test fixed to not expect a stray space between a comma and a newline
  any more (as the original behaviour was fixed by Andrew Burgess a few
  days ago).

> 
> Marco> +  static const char *keywords[] = {
> 
> I think the brace should be on a new line.
> 
> Marco> +      NULL };
> 
> Here too.

I’ve done this and indented the braces by two spaces and the array’s
content by another two spaces.
This seems to match my understanding of the GNU/GDB indentation style, but
I’m not 100% sure it’s the correct one as, in other places in the code
base, this kind of brace is not indented.

Attachment: 0001-Add-gdb.Value.format_string.patch
Description: Binary data

-- 
Marco Barisione