This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: Fix build for avr simulator


* Simon Marchi <simon.marchi@polymtl.ca> [2019-03-28 17:35:32 -0400]:

> On 2019-03-28 17:28, Andrew Burgess wrote:
> > * Dimitar Dimitrov <dimitar@dinux.eu> [2019-03-28 20:05:43 +0200]:
> > 
> > > This commit:
> > > 
> > >   commit ef9866970ce6683d40465fb7c3168f87a1dcd1b7
> > >   Date:   Thu Mar 28 06:40:30 2019 +0900
> > > 
> > >       sim/common: convert sim-arange to use sim-inline
> > > 
> > > Broke simulator build for AVR.
> > > 
> > > sim/avr/ChangeLog:
> > > 
> > > 2019-03-28  Dimitar Dimitrov  <dimitar@dinux.eu>
> > > 
> > >         * interp.c: Include sim-assert.h
> > > 
> > > Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> > 
> > This is fine.
> > 
> > Thanks,
> > Andrew
> 
> I believe that Dimitar doesn't have push access to GDB, so you should
> probably push the patch on his behalf.

Thanks for pointing this out.

I've just been investigating and it turns out many other sim targets
were broken by commit ef9866970ce... I think a more general fix is
required, I'll post one soon.

Thanks,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]